Add passing dependent events to copy calls#2095
Merged
ndgrigorian merged 1 commit intomasterfrom Jun 5, 2025
Merged
Conversation
antonwolfy
requested review from
ndgrigorian,
vlad-perevezentsev and
vtavana
as code owners
|
Deleted rendered PR docs from intelpython.github.com/dpctl, latest should be updated shortly. 🤞 |
|
Array API standard conformance tests for dpctl=0.21.0dev0=py310h93fe807_2 ran successfully. |
Collaborator
ndgrigorian
approved these changes
Jun 5, 2025
Collaborator
ndgrigorian
left a comment
ndgrigorian
left a comment
There was a problem hiding this comment.
This is a good catch
LGTM
Collaborator
|
I misread, this was already done |
ndgrigorian
added a commit
that referenced
this pull request
Jun 6, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The reshape and roll kernels have a special handling for 1-element input array, where
exec_q.copy()is used.But it is still possible that the array data depends on submitted events even in that case with only 1-element.
Thus this PR is fixing the issue with unsafe copying of 1-element input array.
The issue was initially detected in dpnp tests on ARL BMG Linux machine in scope of internal testing.